Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve outstanding resource warnings when running tests #99

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 3, 2024

Closes #62

@cottsay cottsay added the bug label Dec 3, 2024
@cottsay cottsay self-assigned this Dec 3, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, this is great. I would prefer if we ran ROS 2 CI with --packages-above osrf_pycommon before merging this.

@cottsay
Copy link
Member Author

cottsay commented Dec 3, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link

ahcorde commented Dec 3, 2024

Relaunch

  • Linux-aarch64 Build Status

@clalancette
Copy link
Contributor

The warnings on Windows are unrelated (they should be fixed by ros2/rclcpp#2692).

@clalancette clalancette merged commit 8fbffef into master Dec 3, 2024
0 of 13 checks passed
@clalancette clalancette deleted the cottsay/resource-warnings branch December 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of leaked resources and unclosed files when running tests
3 participants